Update translations - #2715
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c9e00ee. Configure here.
| "card_default_image_alt": "Bild in Kürze verfügbar", | ||
| "featured_promotions": { | ||
| "more_offers": "weitere Angebote" | ||
| "more_offers": "{count, plural, ein {weiteres Angebot} other {weitere Angebote}}" |
There was a problem hiding this comment.
Invalid ICU plural keywords
Medium Severity
Several more_offers strings use translated plural selectors such as ét, ein, una, une, and ett. ICU MessageFormat only accepts category keywords like one and other, so the singular branch is never selected and count 1 falls through to other. Other plurals in these same files already use one correctly.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit c9e00ee. Configure here.
| "card_default_image_alt": "画像は近日公開予定", | ||
| "featured_promotions": { | ||
| "more_offers": "その他のオファー" | ||
| "more_offers": "{count, plural、オファーが他} other { 件}}" |
There was a problem hiding this comment.
Broken Japanese plural syntax
High Severity
The Japanese more_offers value is not valid ICU MessageFormat. It uses an ideographic comma after plural and garbles the category structure, so the formatter cannot parse the string. Storefronts in Japanese may show a raw format string or fail to render the featured promotions callout.
Reviewed by Cursor Bugbot for commit c9e00ee. Configure here.
| "card_default_image_alt": "La imagen estará disponible próximamente", | ||
| "featured_promotions": { | ||
| "more_offers": "más ofertas" | ||
| "more_offers": "{count, plural, una {más posibilidades} other {más posibilidades}}" |
There was a problem hiding this comment.
Wrong Spanish offers wording
Medium Severity
Latin American Spanish locales changed más ofertas to más posibilidades. That means “more possibilities,” not “more offers,” so the featured promotions callout now shows the wrong meaning to shoppers. Spain Spanish (es.json) still correctly refers to offers.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit c9e00ee. Configure here.
| "card_default_image_alt": "Image disponible bientôt", | ||
| "featured_promotions": { | ||
| "more_offers": "plus d'offres" | ||
| "more_offers": "{count, plural, une {more offer} other {more offers}}" |
There was a problem hiding this comment.
French text became English
Medium Severity
The French more_offers string replaced the previous plus d'offres with English more offer / more offers. French storefronts will now show English copy in the featured promotions callout instead of localized text.
Reviewed by Cursor Bugbot for commit c9e00ee. Configure here.
1 participant
This pull request was created automatically. Please check new translations, approve and deliver them.
Note
Low Risk
Translation-only changes for a UI label; low functional risk aside from verifying ICU strings parse correctly (especially Japanese).
Overview
Updates
products.featured_promotions.more_offersacross locale JSON files so the label uses ICU{count, plural, …}instead of a fixed string, matching the English pattern (onevsother) for featured promotion callouts on PLP/PDP.Locales get language-specific singular/plural forms where applicable (e.g. German weiteres Angebot / weitere Angebote, Spanish oferta más / más ofertas, Dutch prefix Nog with count).
Review note:
fr.jsonstill uses English more offer / more offers, andja.jsonplural syntax in the diff looks malformed (comma vs 、). Several Spanish regional files use identical singular/plural text (más posibilidades).Reviewed by Cursor Bugbot for commit c9e00ee. Bugbot is set up for automated code reviews on this repo. Configure here.